netdev - Re: [PATCH] fq_codel: dont reinit flow state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1346627860.2563.64.camel@edumazet-glaptop>
Date:	Mon, 03 Sep 2012 01:17:40 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dave Taht <dave.taht@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] fq_codel: dont reinit flow state

On Sat, 2012-09-01 at 11:12 -0700, Dave Taht wrote:
> partial NAK.

Kind of weird to NACK a patch you are the author.

It makes both of us plain fools on netdev, dont do that.

> There is no need to reset dropped either, and resetting quantum or not
> is an interesting question.
> 

Yes but totally unrelated to this patch.

It would be good you pollute threads.

Open a new thread, using RFC attribute or something.

> (in both cases they can be initted at init time)
> 
> Lastly, stats->maxpacket is presently a shared resource in fq_codel,
> and the initial setting of 256 was an artifact some test ns2 code
> (according to kathie). In the case of ack traffic owning a queue, this
> can be 64 or 66 bytes (or larger on ipv6 acks).
> 

I really hope you understand how this maxpacket thing is useless ?

In the real life, we dont send only 66 bytes packets.

maxpacket purpose is to relax codel so that it doesnt drop packet if
the qdisc backlog is small (so about to be empty).

Rename this maxpacket to 'relax_codel_under_that_size' if you want to.

> It's totally unclear if this distinction is important in fq_codel at
> present. :/. Obviously in codel which is a pure FIFO, maxpacket will
> hit the max size really fast.
> 
> A related problem on maxpacket is if someone turns off tso/gso/ufo, it
> remains set to the largest packet seen forever until the qdisc is
> re-initialized.
> This leads to really puzzling behavior... (I'll submit a patch for
> this shortly but not change fq_codel's
> centralized stats)
> 
> I'd be happy (for now) if dropped was preserved,
> and to fiddle with the other ideas a while longer.
> 

There is no dropped field, what are you talking about ?

If you are now unsure of the patch, I can repost the same patch but
as the author.

Its a real obvious one. After an idle period, CODEL needs to compute the
delay between now and previous 'drop_next'

Codel doesnt call codel_vars_init() but in the qdisc init.

fq_codel being FQ + CODEL, it is an error to call codel_vars_init()
outside of init path.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html