netdev - Re: [BUG] TIPC handling of -ERESTARTSYS in connect()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504420FD.4030908@windriver.com>
Date:	Mon, 3 Sep 2012 11:16:13 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	Chris Friesen <chris.friesen@...band.com>
CC:	netdev <netdev@...r.kernel.org>,
	Allan Stephens <allan.stephens@...driver.com>,
	Jon Maloy <jon.maloy@...csson.com>
Subject: Re: [BUG]  TIPC handling of -ERESTARTSYS in connect()


>>
>> It looks like the case where we come in with "sock->state ==
>> SS_LISTENING" has changed. Previously we would return -EOPNOTSUPP but
>> now it'll be -EINVAL. Is that intentional?
>
> Just noticed something else.  In the SS_CONNECTING case I don't think 
> there's any point in setting "res = -EALREADY" since a bit further 
> down it gets set unconditionally anyway.
>
Yes, you are right. Please check v2 version.

Thanks,
Ying

> Chris
>


View attachment "0001-tipc-correct-return-value-of-connect-when-it-is-inte.patch" of type "text/x-diff" (4438 bytes)