netdev - Re: [PATCH] usbnet: drop unneeded check for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120904.123740.1915830868205918256.davem@davemloft.net>
Date:	Tue, 04 Sep 2012 12:37:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	oliver@...kum.org
Cc:	richardcochran@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: drop unneeded check for NULL

From: Oliver Neukum <oliver@...kum.org>
Date: Tue, 04 Sep 2012 18:13:18 +0200

> If that check is ever needed and tx_fixup not needed, the driver will oops here.
> The check is wrong in any case.

Right, we are dealing with two different things here.

Tree-wide there was a blind set of changes to protect skb_tx_timestamp()
calls with a NULL skb check.

But in this specific case, it's completely unnecessary.

So Oliver's change is definitely correct and I will add it to net-next

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html