netdev - Re: [PATCH] xfrm: Workaround incompatibility of ESN and async crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120904.141028.756171698435424565.davem@davemloft.net>
Date:	Tue, 04 Sep 2012 14:10:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	steffen.klassert@...unet.com, netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: Workaround incompatibility of ESN and async
 crypto

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 4 Sep 2012 05:31:55 -0700

> On Tue, Sep 04, 2012 at 12:03:29PM +0200, Steffen Klassert wrote:
>> ESN for esp is defined in RFC 4303. This RFC assumes that the
>> sequence number counters are always up to date. However,
>> this is not true if an async crypto algorithm is employed.
>> 
>> If the sequence number counters are not up to date on sequence
>> number check, we may incorrectly update the upper 32 bit of
>> the sequence number. This leads to a DOS.
>> 
>> We workaround this by comparing the upper sequence number,
>> (used for authentication) with the upper sequence number
>> computed after the async processing. We drop the packet
>> if these numbers are different.
>> 
>> To do this, we introduce a recheck function that does this
>> check in the ESN case.
>> 
>> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> It took me a while to understand the problem but Steffen was
> correct again as usual.

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html