netdev - Re: [PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120904.013439.2021598820983096971.davem@davemloft.net>
Date:	Tue, 04 Sep 2012 01:34:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	naresh@...lsio.com
Cc:	JBottomley@...allels.com, linux-scsi@...r.kernel.org,
	dm@...lsio.com, netdev@...r.kernel.org, chethan@...lsio.com
Subject: Re: [PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

From: Naresh Kumar Inna <naresh@...lsio.com>
Date: Tue, 4 Sep 2012 10:43:24 +0530

> Removing all the module parameters from the driver would put us at a
> disadvantage with respect to tuning the driver and hardware. I have not
> not been able to find alternatives, considering every other driver uses
> module parameters. Could you provide pointers to the generic kernel
> facilities you mentioned in your last post?

Adding module parameters is a cop-out.  It's what you do if you want
to put zero effort into providing good interfaces for your driver.

If an appropriate generic mechanism doesn't exist yet, you simply add
one.

When people add crazy module parameter knobs to networking drivers, we
ask them to extend either ethtool or netlink, as appropriate.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html