netdev - Re: [PATCH v2 1/2] tcp: add generic netlink support for tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120904.154708.2099268692603008096.davem@davemloft.net>
Date:	Tue, 04 Sep 2012 15:47:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ja@....bg
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	shemminger@...tta.com, paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH v2 1/2] tcp: add generic netlink support for tcp_metrics

From: Julian Anastasov <ja@....bg>
Date: Mon, 3 Sep 2012 11:22:15 +0300 (EEST)

> 	BTW, is it appropriate to use kmem_cache for
> metrics and as result call_rcu for freeing?

I think it would work as things are implemented currently in
slab/slub/slob, however I would not rely upon it.

If you do move to a SLAB cache for the tcp metrics objects,
you might consider SLAB_DESTROY_BY_RCU.  It's a very delicate
facility (read the huge comment in linux/slab.h) but I think
it provides the semantics we need for TCP metrics blobs.

Looking forward to v3 :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html