netdev - Re: [PATCH v3 1/3] tcp: add generic netlink support for tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120905.151733.643669381328617078.davem@davemloft.net>
Date:	Wed, 05 Sep 2012 15:17:33 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ja@....bg
Cc:	netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH v3 1/3] tcp: add generic netlink support for tcp_metrics

From: Julian Anastasov <ja@....bg>
Date: Wed,  5 Sep 2012 00:03:15 +0300

> 	Add support for genl "tcp_metrics". No locking
> is changed, only that now we can unlink and delete
> entries after grace period. We implement get/del for
> single entry and dump to support show/flush filtering
> in user space. Del without address attribute causes
> flush for all addresses, sadly under genl_mutex.
> 
> v2:
> - remove rcu_assign_pointer as suggested by Eric Dumazet,
> it is not needed because there are no other writes under lock
> - move the flushing code in tcp_metrics_flush_all
> 
> v3:
> - remove synchronize_rcu on flush as suggested by Eric Dumazet
> 
> Signed-off-by: Julian Anastasov <ja@....bg>

Looks great, applied to net-next, thanks Julian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html