netdev - Re: [RFC PATCH v3] ipv6: fix handling of blackhole and prohibit routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 05 Sep 2012 17:50:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH v3] ipv6: fix handling of blackhole and prohibit
 routes

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Wed,  5 Sep 2012 08:12:42 -0400

> When adding a blackhole or a prohibit route, they were handling like classic
> routes. Moreover, it was only possible to add this kind of routes by specifying
> an interface.
> 
> Bug already reported here:
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498498
> 
> Before the patch:
>   $ ip route add blackhole 2001::1/128
>   RTNETLINK answers: No such device
>   $ ip route add blackhole 2001::1/128 dev eth0
>   $ ip -6 route | grep 2001
>   2001::1 dev eth0  metric 1024
> 
> After:
>   $ ip route add blackhole 2001::1/128
>   $ ip -6 route | grep 2001
>   blackhole 2001::1 dev lo  metric 1024  error -22
> 
> v2: wrong patch
> v3: add a field fc_type in struct fib6_config to store RTN_* type
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

I like this a lot more than your original patch, applied to net-next,
thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html