netdev - Re: [PATCH] ceph: [PATCH] ceph: use list_move_tail instead of list_del/list_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 5 Sep 2012 08:48:31 -0700 (PDT)
From:	Sage Weil <sage@...tank.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
cc:	davem@...emloft.net, yongjun_wei@...ndmicro.com.cn,
	ceph-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] ceph: [PATCH] ceph: use list_move_tail instead of
 list_del/list_add_tail

Applied to the ceph queue. Thanks!
sage


On Wed, 5 Sep 2012, Wei Yongjun wrote:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  net/ceph/pagelist.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ceph/pagelist.c b/net/ceph/pagelist.c
> index 665cd23..92866be 100644
> --- a/net/ceph/pagelist.c
> +++ b/net/ceph/pagelist.c
> @@ -1,4 +1,3 @@
> -
>  #include <linux/module.h>
>  #include <linux/gfp.h>
>  #include <linux/pagemap.h>
> @@ -134,8 +133,8 @@ int ceph_pagelist_truncate(struct ceph_pagelist *pl,
>  	ceph_pagelist_unmap_tail(pl);
>  	while (pl->head.prev != c->page_lru) {
>  		page = list_entry(pl->head.prev, struct page, lru);
> -		list_del(&page->lru);                /* remove from pagelist */
> -		list_add_tail(&page->lru, &pl->free_list); /* add to reserve */
> +		/* move from pagelist to reserve */
> +		list_move_tail(&page->lru, &pl->free_list);
>  		++pl->num_pages_free;
>  	}
>  	pl->room = c->room;
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html