netdev - Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120905092957.7d24187e@nehalam.linuxnetplumber.net>
Date:	Wed, 5 Sep 2012 09:29:57 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Naresh Kumar Inna <naresh@...lsio.com>
Cc:	JBottomley@...allels.com, linux-scsi@...r.kernel.org,
	dm@...lsio.com, leedom@...lsio.com, netdev@...r.kernel.org,
	chethan@...lsio.com
Subject: Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission
 (sources part 2).

On Wed,  5 Sep 2012 18:03:55 +0530
Naresh Kumar Inna <naresh@...lsio.com> wrote:

> This patch contains code for driver initialization, driver resource
> allocation and the Work Request module functionality. Driver initialization
> includes module entry/exit points, registration with PCI, FC transport and
> SCSI mid layer subsystems. The Work Request module provides services for
> allocation of DMA queues, posting Work Requests on them and processing
> completions.
> 
> Signed-off-by: Naresh Kumar Inna <naresh@...lsio.com>

Although the comments say you are using proc fs, there is no
code here related to that.

Any use of debugfs must be conditional the DEBUG_FS kernel configuration
parameter.  Your code probably will break if DEBUG_FS is not
enabled.  For a possible alternative see how a sub-config parameter
was added in sky2 driver.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html