netdev - Re: [PATCH net-next] ipv6: Export nd_tbl to allow modules to support IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120905.130636.2295422323329670307.davem@davemloft.net>
Date:	Wed, 05 Sep 2012 13:06:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: Export nd_tbl to allow modules to
 support IPv6

From: Thomas Graf <tgraf@...g.ch>
Date: Wed,  5 Sep 2012 13:14:08 +0200

> It does not make sense to export these functions if we don't
> export the table itself as well.

Yes it does make perfect sense.  It's exported for the sake of the
_implementation_ of a neighbour table in a kernel module.

I do not want to add more users with direct access to the neighbour
tables, because it is therefore impossible to go and add the inline
refcount'less lookups et al. to those external users.

So if one of our goals is to move towards a situation where all neigh
accesses are refcount'less, having those external users makes that
nearly impossible.

Instead, I'd rather see patches that mark arp_tbl as being exported
only for internal usage inside of the tree, so that we can reach that
goal.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html