lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Thu,  6 Sep 2012 02:21:57 -0400
From:	Sony Chacko <sony.chacko@...gic.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com,
	Sony Chacko <sony.chacko@...gic.com>
Subject: [PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA

From: Sony Chacko <sony.chacko@...gic.com>

>From: David Miller [mailto:davem@...emloft.net]

>From: David Miller [mailto:davem@...emloft.net] 
>Sent: Friday, August 31, 2012 1:05 PM

> +static inline int
> +qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 
> +rate) {
> +	return adapter->nic_ops->config_led(adapter, state, rate);
> +
> +}
> +

>Please get rid of those unnecessary empty lines in the function bodies.

>From: David Miller <davem@...emloft.net>
>Date: Fri, 31 Aug 2012 20:00:35 -0400 (EDT)

>Also in patch #5:
>-	qlcnic_config_ipaddr(adapter, ifa->ifa_address, QLCNIC_IP_UP);
>+	qlcnic_config_ipaddr(adapter, ifa->ifa_address,
>+						 QLCNIC_IP_UP);

>This is not the correct way to format multi-line function calls,
>the correct way is:

>	qlcnic_config_ipaddr(adapter, ifa->ifa_address,
>			     QLCNIC_IP_UP);

I have made the changes as you suggested above.
Please apply the updated 12 patch series to net-next.

Thanks,
Sony
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists