netdev - Re: [PATCH v2] ethtool: don't overwrite useful bits in advertising bitfield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1346958348.2714.34.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 6 Sep 2012 20:05:48 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Johan Gunnarsson <johan.gunnarsson@...s.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH v2] ethtool: don't overwrite useful bits in advertising
 bitfield

On Fri, 2012-08-24 at 13:32 +0200, Johan Gunnarsson wrote:
> There are bits in this bitfield that we want to leave untouched (PAUSE
> and ASYM_PAUSE bits) when changing other bits (speed and duplex bits.)
> Previously, these were always overwritten to zero when running commands
> like "ethtool -s eth0 speed 10 duplex full autoneg off".
> 
> Signed-off-by: Johan Gunnarsson <johangu@...s.com>
[...]

Applied, thanks.  I made some minor fixes to spelling and formatting.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html