netdev - Re: [net-next.git 4/7] stmmac: add Rx watchdog optimization to mitigate the DMA irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50483D56.1020208@st.com>
Date:	Thu, 06 Sep 2012 08:06:14 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	David Miller <davem@...emloft.net>
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [net-next.git 4/7] stmmac: add Rx watchdog optimization to mitigate
 the DMA irqs

On 9/5/2012 7:16 PM, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Wed, 5 Sep 2012 17:14:35 +0100
> 
>> On Wed, 2012-09-05 at 17:03 +0200, Giuseppe CAVALLARO wrote:
>>> GMAC devices newer than databook 3.50 has an embedded timer
>>> that can be used for mitigating the number of interrupts.
>>> So this patch adds this optimizations.
>>> Old MAC will continue to use NAPI.
>> [...]
>>
>> Interrupt moderation is *not* a substitute for NAPI; you should continue
>> using NAPI as well.
> 
> Absolutely correct, these two facilities are _complementary_ not _exlusive_.
> 
> In fact, the most optimal driver will use NAPI with relatively short HW
> mitigation settings.
> 

David, Ben,

many thanks for your notes and review. I'll apply them and re-test the
driver using NAPI plus the HW wdt feature.

Regards
Peppe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html