netdev - Re: [PATCH net-next] ipv4/route: arg delay is useless in rt_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5049CF77.2060408@6wind.com>
Date:	Fri, 07 Sep 2012 12:41:59 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv4/route: arg delay is useless in rt_cache_flush()

Le 07/09/2012 12:29, Eric Dumazet a écrit :
> On Fri, 2012-09-07 at 11:31 +0200, Nicolas Dichtel wrote:
>> Since route cache deletion (89aef8921bfbac22f), delay is no
>> more used. Remove it.
>>
> ...
>
>>   #ifdef CONFIG_SYSCTL
>> @@ -2354,16 +2350,12 @@ static int ipv4_sysctl_rtcache_flush(ctl_table *__ctl, int write,
>>   					size_t *lenp, loff_t *ppos)
>>   {
>>   	if (write) {
>> -		int flush_delay;
>>   		ctl_table ctl;
>>   		struct net *net;
>>
>>   		memcpy(&ctl, __ctl, sizeof(ctl));
>> -		ctl.data = &flush_delay;
>> -		proc_dointvec(&ctl, write, buffer, lenp, ppos);
>> -
>>   		net = (struct net *)__ctl->extra1;
>> -		rt_cache_flush(net, flush_delay);
>> +		rt_cache_flush(net);
>>   		return 0;
>>   	}
>>
>
> Why do you keep ctl then ?
>
> 	if (write) {
> 		rt_cache_flush((struct net *)__ctl->extra1);
> 		return 0;
> 	}
>
>
Right, there is no reason.


Regards,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html