netdev - Re: [PATCH 1/2] netlink: kill netlink_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120907.141634.1240608655518041923.davem@davemloft.net>
Date:	Fri, 07 Sep 2012 14:16:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] netlink: kill netlink_set_nonroot

From: pablo@...filter.org
Date: Thu,  6 Sep 2012 14:31:51 +0200

> From: Pablo Neira Ayuso <pablo@...filter.org>
> 
> Replace netlink_set_nonroot by one new field `flags' in
> struct netlink_kernel_cfg that is passed to netlink_kernel_create.
> 
> This patch also renames NL_NONROOT_* to NL_CFG_F_NONROOT_* since
> now the flags field in nl_table is generic (so we can add more
> flags if needed in the future).
> 
> Also adjust all callers in the net-next tree to use these flags
> instead of netlink_set_nonroot.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Please redo these patches and test them with infiniband enabled:

drivers/infiniband/core/netlink.c: In function ‘ibnl_init’:
drivers/infiniband/core/netlink.c:180:2: warning: passing argument 3 of ‘netlink_kernel_create’ from incompatible pointer type [enabled by default]
In file included from include/net/netlink.h:5:0,
                 from drivers/infiniband/core/netlink.c:36:
include/linux/netlink.h:195:1: note: expected ‘struct netlink_kernel_cfg *’ but argument is of type ‘struct module *’
drivers/infiniband/core/netlink.c:180:2: error: too many arguments to function ‘netlink_kernel_create’
In file included from include/net/netlink.h:5:0,
                 from drivers/infiniband/core/netlink.c:36:
include/linux/netlink.h:195:1: note: declared here
make[3]: *** [drivers/infiniband/core/netlink.o] Error 1
make[2]: *** [drivers/infiniband/core] Error 2
make[2]: *** Waiting for unfinished jobs....

Thanks.