netdev - Re: [PATCH] scsi_netlink: Remove dead and buggy code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120908.185105.2033125004492160106.davem@davemloft.net>
Date:	Sat, 08 Sep 2012 18:51:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, James.Bottomley@...allels.com,
	James.Smart@...lex.Com
Subject: Re: [PATCH] scsi_netlink: Remove dead and buggy code

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Fri, 07 Sep 2012 15:39:21 -0700

> 
> The scsi netlink code confuses the netlink port id with a process id,
> going so far as to read NETLINK_CREDS(skb)->pid instead of the correct
> NETLINK_CB(skb).pid.  Fortunately it does not matter because nothing
> registers to respond to scsi netlink requests.
> 
> The only interesting use of the scsi_netlink interface is
> fc_host_post_vendor_event which sends a netlink multicast message.
> 
> Since nothing registers to handle scsi netlink messages kill all of the
> registration logic, while retaining the same error handling behavior
> preserving the userspace visible behavior and removing all of the
> confused code that thought a netlink port id was a process id.
> 
> This was tested with a kernel allyesconfig build which had no problems.
> 
> Cc: James Bottomley <James.Bottomley@...allels.com>
> Cc: James Smart <James.Smart@...lex.Com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Yeah I can't see anyone, anywhere, using these scsi_send_nl_*()
interfaces at all.

When I get an ACK from the scsi folks I'll add this to net-next,
thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html