netdev - Re: [PATCH] configure: Add search path for 64bit library.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 9 Sep 2012 21:42:58 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...i.de>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	Ben Hutchings <bhutchings@...arflare.com>,
	Li Wei <lw@...fujitsu.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] configure: Add search path for 64bit library.


On Monday 2012-08-13 18:33, Stephen Hemminger wrote:
>> > > >  	IPT_LIB_DIR=""
>> > > > -	for dir in /lib /usr/lib /usr/local/lib
>> > > > +	for dir in /lib /usr/lib /usr/local/lib /lib64 /usr/lib64 /usr/local/lib64
>> > > >  	do
>> > > >  		for file in $dir/{xtables,iptables}/lib*t_*so ; do
>> > > >  			if [ -f $file ]; then
>> > > 
>> > > I think this should be done with pkg-config:
>> > > 
>> > >     pkg-config --variable=xtlibdir xtables
>> > 
>> > Does every distro have pkg-config or does more logic need to be done here?
>> 
>> Every distro has pkg-config; the question is whether you want to support
>> library versions that don't include a pkg-config file (xtables.pc), if
>> they exist.
>
>Let's do pkg-config first, and as a fallback keep the old code and only
>look in the same old places.

Every distro that has libxtables.so also has the .pc file.

The obvious reason to have the .pc file is to render such error
prone static path searching redundant.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html