netdev - Re: [PATCH v2] rndis_wlan: remove pointless check from rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120910183339.19525dpw8ii5bk9c@www.81.fi>
Date:	Mon, 10 Sep 2012 18:33:39 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	linville@...driver.com, yongjun_wei@...ndmicro.com.cn,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] rndis_wlan: remove pointless check from
 rndis_scan()

Quoting Wei Yongjun <weiyj.lk@...il.com>:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> In rndis_scan(), 'request' is actually always valid pointer and
> the !request check is unneeded, so remove it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Acked-by: Jussi Kivilinna <jussi.kivilinna@...et.fi>

> ---
>  drivers/net/wireless/rndis_wlan.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rndis_wlan.c  
> b/drivers/net/wireless/rndis_wlan.c
> index 7a4ae9e..bd1f0cb 100644
> --- a/drivers/net/wireless/rndis_wlan.c
> +++ b/drivers/net/wireless/rndis_wlan.c
> @@ -1959,9 +1959,6 @@ static int rndis_scan(struct wiphy *wiphy,
>  	 */
>  	rndis_check_bssid_list(usbdev, NULL, NULL);
>
> -	if (!request)
> -		return -EINVAL;
> -
>  	if (priv->scan_request && priv->scan_request != request)
>  		return -EBUSY;
>
>
>
>
>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html