netdev - Re: [PATCH net] ixp4xx_hss: fix build failure after logging conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1347296665.2823.13.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 10 Sep 2012 18:04:25 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Florian Fainelli <florian@...nwrt.org>
CC:	<netdev@...r.kernel.org>, <khc@...waw.pl>, <joe@...ches.com>,
	David Miller <davem@...emloft.net>, <stable@...r.kernel.org>
Subject: Re: [PATCH net] ixp4xx_hss: fix build failure after logging
 conversion

On Mon, 2012-09-10 at 10:43 +0200, Florian Fainelli wrote:
> Commit c75bb2c6f0cf455c23e60f14d780e841dd47f801 (ixp4xx_hss: Update to
> current logging forms) converted the ixp4xx_hss module to use the current
> logging macros, but forgot to include linux/module.h, leading to the
> following build failures:
> 
>   CC [M]  drivers/net/wan/ixp4xx_hss.o
>  drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')'
>  before string constant
>  drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')'
>  before string constant
>  drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')'
>  before string constant
>  drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')'
>  before string constant
>  make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1
> 
> CC: stable@...r.kernel.org
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> ---
> [stable: 3.1+]

The versions to receive stable updates should be noted on the inline Cc
line, not in non-committed comments.  (But David prefers to collect up
networking patches in his own stable queue rather than using the inline
Cc mechanism.  So the Cc may not be appropriate at all.)

Ben.

>  drivers/net/wan/ixp4xx_hss.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
> index aaaca9a..3f575af 100644
> --- a/drivers/net/wan/ixp4xx_hss.c
> +++ b/drivers/net/wan/ixp4xx_hss.c
> @@ -10,6 +10,7 @@
>  
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
> +#include <linux/module.h>
>  #include <linux/bitops.h>
>  #include <linux/cdev.h>
>  #include <linux/dma-mapping.h>

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html