netdev - Re: [PATCH v2 2/2] iproute2: use libgenl in ipl2tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120911140213.6c34e892@nehalam.linuxnetplumber.net>
Date:	Tue, 11 Sep 2012 14:02:13 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Julian Anastasov <ja@....bg>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iproute2: use libgenl in ipl2tp

On Tue, 11 Sep 2012 23:22:41 +0300 (EEST)
Julian Anastasov <ja@....bg> wrote:

> 
> 	Hello,
> 
> On Tue, 11 Sep 2012, Stephen Hemminger wrote:
> 
> > On Tue, 11 Sep 2012 12:04:34 +0300
> > Julian Anastasov <ja@....bg> wrote:
> > 
> > > 	Use the common code from libgenl.c to parse family.
> > > 
> > > Signed-off-by: Julian Anastasov <ja@....bg>
> > 
> > I applied these two but made some modifications:
> >   1. change to GENL_INITIALIZER
> >   2. use GENL_INITIALIZER
> 
> 	I used 2 defines, so that in tcp_metrics.c I can
> use different initialization depending on the command.
> But as the structure is unnamed may be it is better to have
> single define (both defines merged as you proposed) and
> later just to update cmd and flags if needed.
> 
> Regards
> 
> --
> Julian Anastasov <ja@....bg>

Changes accepted any time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html