netdev - Re: [PATCH] staging: r8712u: fix bug in r8712_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKNFNKoowxSsbkV_tsBDG1uZeuWBDxPQFQoHQZ2R2O7Y6hnrmA@mail.gmail.com>
Date:	Wed, 12 Sep 2012 20:52:14 +0300
From:	Aki Parviainen <aki.parviainen@....fi>
To:	edumazet@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] staging: r8712u: fix bug in r8712_recv_indicatepkt()

>From: Eric Dumazet <edumazet@...gle.com>
>
>64bit arches have a buggy r8712u driver, let's fix it.
>
>skb->tail must be set properly or network stack behavior is undefined.
>
>Addresses https://bugzilla.redhat.com/show_bug.cgi?id=847525
>Addresses https://bugzilla.kernel.org/show_bug.cgi?id=45071
>
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>Cc: Larry Finger <Larry.Finger@...inger.net>
>Cc: Dave Jones <davej@...hat.com>
>Cc: stable@...r.kernel.org [2.6.37+]

Tested this patch on 64bit linux-3.6-rc5 & fixes problem for me. Thank
you very much for fixing this very annoying & long time open bug!

Tested-by: Aki Parviainen <aki.parviainen@....fi>

Aki

>---
> drivers/staging/rtl8712/recv_linux.c |    7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/drivers/staging/rtl8712/recv_linux.c b/drivers/staging/rtl8712/recv_linux.c
>index 0e26d5f..495ee12 100644
>--- a/drivers/staging/rtl8712/recv_linux.c
>+++ b/drivers/staging/rtl8712/recv_linux.c
>@@ -117,13 +117,8 @@ void r8712_recv_indicatepkt(struct _adapter *padapter,
>  if (skb == NULL)
>  goto _recv_indicatepkt_drop;
>  skb->data = precv_frame->u.hdr.rx_data;
>-#ifdef NET_SKBUFF_DATA_USES_OFFSET
>- skb->tail = (sk_buff_data_t)(precv_frame->u.hdr.rx_tail -
>-     precv_frame->u.hdr.rx_head);
>-#else
>- skb->tail = (sk_buff_data_t)precv_frame->u.hdr.rx_tail;
>-#endif
>  skb->len = precv_frame->u.hdr.len;
>+ skb_set_tail_pointer(skb, skb->len);
>  if ((pattrib->tcpchk_valid == 1) && (pattrib->tcp_chkrpt == 1))
>  skb->ip_summed = CHECKSUM_UNNECESSARY;
>  else
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html