netdev - Re: [PATCH] mISDN: Fix wrong usage of flush_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120913.145937.235693485700301637.davem@davemloft.net>
Date:	Thu, 13 Sep 2012 14:59:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	keil@...systems.de
Cc:	netdev@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] mISDN: Fix wrong usage of flush_work_sync while
 holding locks

From: Karsten Keil <keil@...systems.de>
Date: Thu, 13 Sep 2012 16:36:20 +0200

> It is a bad idea to hold a spinlock and call flush_work_sync.
> Move the workqueue cleanup outside the spinlock and use cancel_work_sync,
> on closing the channel this seems to be the more correct function.
> Remove the never used and constant return value of mISDN_freebchannel.
> 
> Signed-off-by: Karsten Keil <keil@...systems.de>
> Cc: <stable@...nel.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html