netdev - Re: [PATCH 3/4] net_sched: gred: fix qave reporting via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50521F97.20503@mojatatu.com>
Date:	Thu, 13 Sep 2012 14:01:59 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	David Ward <david.ward@...mit.edu>
CC:	netdev@...r.kernel.org, Bruce Osler <brosler@...co.com>,
	Cyril Chemparathy <cyril@...com>
Subject: Re: [PATCH 3/4] net_sched: gred: fix qave reporting via netlink

On 12-09-13 11:22 AM, David Ward wrote:
> q->vars.qavg is a Wlog scaled value, but q->backlog is not. In order
> to pass q->vars.qavg as the backlog value, we need to un-scale it.
> Additionally, the qave value returned via netlink should not be Wlog
> scaled, so we need to un-scale the result of red_calc_qavg().
>
> This caused artificially high values for "Average Queue" to be shown
> by 'tc -s -d qdisc', but did not affect the actual operation of GRED.
>
> Signed-off-by: David Ward <david.ward@...mit.edu>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html