netdev - Re: [RFC/RFT 14/15] rtlwifi: Modify files for addition of rtl8723ae

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mx0t3zin.fsf@purkki.adurom.net>
Date:	Fri, 14 Sep 2012 09:10:56 +0300
From:	Kalle Valo <kvalo@...rom.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Julian Calaby <julian.calaby@...il.com>, linville@...driver.com,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	chaoming_li@...lsil.com.cn
Subject: Re: [RFC/RFT 14/15] rtlwifi: Modify files for addition of rtl8723ae

Larry Finger <Larry.Finger@...inger.net> writes:

>> Is this supposed to be bit #29 - I notice that COMP_USB is also bit 29.
>
> Yes, that is OK. One will only be used for PCI-based drivers, and the
> other is obviously for USB. As nearly all the bits of a 32-bit
> quantity are used, I wanted to save one if possible.
>
> In the final version, I'll code this as
>
> #define COMP_USB                       BIT(29)
> #define COMP_EASY_CONCURRENT           COMP_USB
>
> That way will be more obvious.

You could also add a comment explaining it, just to make sure that
everyone understands it.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html