netdev - Regarding group_forward_mask in bridge in 3.4 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADAe=++yAm3t-ZqMKy9h-Rda5=pOYQD2-cKUd3S1VKmBZQfT9A@mail.gmail.com>
Date:	Mon, 17 Sep 2012 20:13:48 +0530
From:	Ajith Adapa <adapa.ajith@...il.com>
To:	netdev@...r.kernel.org
Cc:	Stephen Hemminger <shemminger@...tta.com>
Subject: Regarding group_forward_mask in bridge in 3.4 kernel

Hi,

I am trying to enable group_fwd_mask in bridge by giving the below
command so that it can forward provider bpdu's whose destination
address is 01-80-C2-00-00-08.

echo 8 > /sys/class/net/vpc1_br/bridge/group_fwd_mask

But still the provider BPDU's are dropped by the bridge. After some
debugging I have found that logic in br_input.c has some issue

                switch (dest[5]) {
                case 0x00:      /* Bridge Group Address */
                        /* If STP is turned off,
                           then must forward to keep loop detection */
                        if (p->br->stp_enabled == BR_NO_STP)
                                goto forward;
                        break;

                case 0x01:      /* IEEE MAC (Pause) */
                        goto drop;

                default:
                        /* Allow selective forwarding for most other
protocols */
                        if (p->br->group_fwd_mask & (1u << dest[5]))
                                goto forward;
                }

In my case dest[5] is 8 and p->br->group_fwd_mask is 8. The default
case is triggered but the expression in if condition
is always ZERO as a result BPDU is not forwarded.

Am I giving wrong value for group_fwd_mask ?? I tried other values but
seems only 8 and 0 is accepted.

Regards,
Ajith
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html