netdev - Re: [V4 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1347957374.2388.15.camel@dabdike.int.hansenpartnership.com>
Date:	Tue, 18 Sep 2012 09:36:14 +0100
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Naresh Kumar Inna <naresh@...lsio.com>
Cc:	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Dimitrios Michailidis <dm@...lsio.com>,
	Casey Leedom <leedom@...lsio.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Chethan Seshadri <chethan@...lsio.com>
Subject: Re: [V4 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

On Tue, 2012-09-18 at 09:54 +0530, Naresh Kumar Inna wrote:
> Hi James,
> 
> Could you please consider merging version V4 of the driver patches, if
> you think they are in good shape now?

Well, definitely not yet; you seem to have missed the memo on readq:

  CC [M]  drivers/scsi/cxgbi/cxgb4i/cxgb4i.o
drivers/scsi/csiostor/csio_hw.c: In function ‘csio_hw_mc_read’:
drivers/scsi/csiostor/csio_hw.c:194:3: error: implicit declaration of
function ‘readq’ [-Werror=implicit-function-declaration]

It's only defined on platforms which can support an atomic 64 bit
operation (which is mostly not any 32 bit platforms) ... so this could
do with compile testing on those.

To see how to handle readq/writeq in the 32 bit case, see the uses in
fnic or qla2xxx

You also have a couple of unnecessary version.h includes.

Since you're a new driver, could you not do a correctly unlocked
queuecommand routine?  You'll find the way you've currently got it coded
(holding the host lock for the entire queuecommand routine) is very
performance detrimental.

You have a lot of locking statements which aren't easy to audit by hand
because there are multiple unlocks.  Things like this:

csio_scan_finished(struct Scsi_Host *shost, unsigned long time)
{
	struct csio_lnode *ln = shost_priv(shost);
	int rv = 0;

	spin_lock_irq(shost->host_lock);
	if (!ln->hwp || csio_list_deleted(&ln->sm.sm_list)) {
		spin_unlock_irq(shost->host_lock);
		return 1;
	}

	rv = csio_scan_done(ln, jiffies, time, csio_max_scan_tmo * HZ,
			    csio_delta_scan_tmo * HZ);

	spin_unlock_irq(shost->host_lock);

	return rv;
}

Are better coded as

csio_scan_finished(struct Scsi_Host *shost, unsigned long time)
{
	struct csio_lnode *ln = shost_priv(shost);
	int rv = 1;

	spin_lock_irq(shost->host_lock);
	if (!ln->hwp || csio_list_deleted(&ln->sm.sm_list))
		goto out;

	rv = csio_scan_done(ln, jiffies, time, csio_max_scan_tmo * HZ,
			    csio_delta_scan_tmo * HZ);

 out:
	spin_unlock_irq(shost->host_lock);

	return rv;
}

It's shorter and the unlock clearly matches the lock.  You could even
invert the if logic and just make the csio_scan_done() conditional on it
avoiding the goto.

I'd also really like the people who understand FC to take a look over
this as well.

James

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html