netdev - Re: [PATCH 0/6] llc2: Simplify llc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120918174955.GD29217@decadent.org.uk>
Date:	Tue, 18 Sep 2012 18:49:55 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	acme@...stprotocols.net, netdev@...r.kernel.org
Subject: Re: [PATCH 0/6] llc2: Simplify llc_station

On Mon, Sep 17, 2012 at 01:12:37PM -0400, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Mon, 17 Sep 2012 13:10:17 -0400 (EDT)
> 
> > From: David Miller <davem@...emloft.net>
> > Date: Mon, 17 Sep 2012 13:05:31 -0400 (EDT)
> > 
> >> From: Ben Hutchings <ben@...adent.org.uk>
> >> Date: Sun, 16 Sep 2012 04:09:42 +0100
> >> 
> >>> There seem to have been some grand plans for llc_station, but as they
> >>> haven't been fulfilled it's just unnecessarily complicated.
> >> 
> >> I went over these a few times, they look correct, so I am going
> >> to apply them to net-next.
> >> 
> >> If there are any problems let's hope that exposure in the tree
> >> helps shake those out.
> > 
> > It doesn't even build properly, please fix this and resubmit:
> > 
> > ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined!
> 
> Actually, since I trusted you when you said you build tested this,
> I pushed it out to net-next pre-maturely.
> 
> I'm going to fix this meanwhile by simply removing the sysctl that
> references this symbol.
> 
> But you need to check for me whether that's ok or not.
 
The sysctl had no effect so I think it's fairly safe to assume nothing
depends on it.  Thanks.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html