netdev - Re: [PATCH] bnx2x: fix rx checksum validation for IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120918.161755.379639106500504747.davem@davemloft.net>
Date:	Tue, 18 Sep 2012 16:17:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	mschmidt@...hat.com, netdev@...r.kernel.org, eilong@...adcom.com,
	edumazet@...gle.com, yanivr@...adcom.com, yuvalmin@...adcom.com,
	meravs@...adcom.com, evansr@...gle.com, therbert@...gle.com,
	willemb@...gle.com, hskinnemoen@...gle.com
Subject: Re: [PATCH] bnx2x: fix rx checksum validation for IPv6

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 14 Sep 2012 01:14:39 +0200

> On Fri, 2012-09-14 at 00:59 +0200, Michal Schmidt wrote:
>> Commit d6cb3e41 "bnx2x: fix checksum validation" caused a performance
>> regression for IPv6. Rx checksum offload does not work. IPv6 packets
>> are passed to the stack with CHECKSUM_NONE.
>> 
>> The hardware obviously cannot perform IP checksum validation for IPv6,
>> because there is no checksum in the IPv6 header. This should not prevent
>> us from setting CHECKSUM_UNNECESSARY.
>> 
>> Tested on BCM57711.
>> 
>> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
 ...
> Thanks for fixing this bug !
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> 
> 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html