netdev - Re: [PATCH] net: fix memory leak on oom with zerocopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120918.162514.1950372124026735732.davem@davemloft.net>
Date:	Tue, 18 Sep 2012 16:25:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	edumazet@...gle.com, bhutchings@...arflare.com,
	mirq-linux@...e.qmqm.pl, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: fix memory leak on oom with zerocopy

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Sun, 16 Sep 2012 11:44:16 +0300

> If orphan flags fails, we don't free the skb
> on receive, which leaks the skb memory.
> 
> Return value was also wrong: netif_receive_skb
> is supposed to return NET_RX_DROP, not ENOMEM.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Applied, thanks Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html