netdev - Re: [PATCH] tcp: fix regression in urgent data handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120918.162651.1368150594651951061.davem@davemloft.net>
Date:	Tue, 18 Sep 2012 16:26:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, springl-k@....bfw.de,
	alexander.h.duyck@...el.com
Subject: Re: [PATCH] tcp: fix regression in urgent data handling

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 18 Sep 2012 00:51:39 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Stephan Springl found that commit 1402d366019fed "tcp: introduce
> tcp_try_coalesce" introduced a regression for rlogin
> 
> It turns out problem comes from TCP urgent data handling and
> a change in behavior in input path.
> 
> rlogin sends two one-byte packets with URG ptr set, and when next data
> frame is coalesced, we lack sk_data_ready() calls to wakeup consumer.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Stephan Springl <springl-k@....bfw.de>
> Cc: Alexander Duyck <alexander.h.duyck@...el.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html