netdev - Re: [PATCH] sched: fix virtual-start-time update in QFQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120919.162506.1493337375457097539.davem@davemloft.net>
Date:	Wed, 19 Sep 2012 16:25:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	paolo.valente@...more.it
Cc:	shemminger@...tta.com, jhs@...atatu.com, fchecconi@...il.com,
	rizzo@....unipi.it, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: fix virtual-start-time update in QFQ

From: Paolo Valente <paolo.valente@...more.it>
Date: Sat, 15 Sep 2012 12:41:35 +0200

> If the old timestamps of a class, say cl, are stale when the class
> becomes active, then QFQ may assign to cl a much higher start time
> than the maximum value allowed. This may happen when QFQ assigns to
> the start time of cl the finish time of a group whose classes are
> characterized by a higher value of the ratio
> max_class_pkt/weight_of_the_class with respect to that of
> cl. Inserting a class with a too high start time into the bucket list
> corrupts the data structure and may eventually lead to crashes.
> This patch limits the maximum start time assigned to a class.
> 
> Signed-off-by: Paolo Valente <paolo.valente@...more.it>

Applied and queued up for -stable, thanks.

Please use "pkt_sched" instead of just plain "sched" in the prefixes
of your subject lines for packet scheduler changes so such changes
can be distinguished from process scheduler changes.

I fixed it up for you this time.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html