netdev - Re: [Patch net-next] l2tp: fix compile error when CONFIG_IPV6=m and CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120919.164403.1265757047954729748.davem@davemloft.net>
Date:	Wed, 19 Sep 2012 16:44:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [Patch net-next] l2tp: fix compile error when CONFIG_IPV6=m
 and CONFIG_L2TP=y

From: Cong Wang <amwang@...hat.com>
Date: Tue, 18 Sep 2012 13:54:02 +0800

> When CONFIG_IPV6=m and CONFIG_L2TP=y, I got the following compile error:
 ...
> This is due to l2tp uses symbols from IPV6, so when l2tp is
> builtin, IPV6 has to be builtin too.
> 
> Cc: David Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>

The correct way to express this is:

	depends on (IPV6 || IPV6=n)

Which results in the KCONFIG option only being offers in modes
compatible with the dependency.  Using a 'select' doesn't work
properly in these kinds of cases.

Anyways, grep for that string to see how it is used in other similar
situations.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html