netdev - Re: [PATCH] net/core: fix comment in skb_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348031296.26523.277.camel@edumazet-glaptop>
Date:	Wed, 19 Sep 2012 07:08:16 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/core: fix comment in skb_try_coalesce

On Wed, 2012-09-19 at 10:53 +0800, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> It should be the skb which is not cloned
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>  net/core/skbuff.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index fe00d12..354a4e4 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -3502,7 +3502,9 @@ bool skb_try_coalesce(struct sk_buff *to, struct sk_buff *from,
>  	if (!skb_cloned(from))
>  		skb_shinfo(from)->nr_frags = 0;
>  
> -	/* if the skb is cloned this does nothing since we set nr_frags to 0 */
> +	/* if the skb is not cloned this does nothing
> +	 * since we set nr_frags to 0.
> +	 */
>  	for (i = 0; i < skb_shinfo(from)->nr_frags; i++)
>  		skb_frag_ref(from, i);
>  

Yes I saw that yesterday and was about to submit the same change (more
or less)

Acked-by: Eric Dumazet <edumazet@...gle.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html