netdev - Re: Davicom DM9000C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120919183937.3f63104f@neptune.home>
Date:	Wed, 19 Sep 2012 18:39:37 +0200
From:	Bruno Prémont <bonbons@...ux-vserver.org>
To:	Allen Huang (黃偉格) 
	<allen_huang@...icom.com.tw>
Cc:	<linux-kernel@...r.kernel.org>,
	"'Michael Chen'" <michael_chen@...l.davicom.com.tw>,
	"'Charles'" <charles_tsai@...icom.com.tw>,
	"'Joseph Chang'" <joseph_chang@...l.davicom.com.tw>,
	Linux network list <netdev@...r.kernel.org>
Subject: Re: Davicom DM9000C driver

Hi Allen,

[CCing netdev, keeping .c/.h source attached]

On Wed, 19 September 2012 Allen Huang (黃偉格)  <allen_huang@...icom.com.tw> wrote:
> I'm Allen Huang from Davicom. We are hereby opensourcing the linux
> driver for our DM9000C. 

Ah, from looking at the code DM9000C looks like it is some nerwork chip,
what platforms does it show up on?

> We would appreciate any comments that you have on our driver and
> whether it is ready to go into the kernel. Please see DM9000C driver in the
> attachment.

It would be nice if you could include the changes to Kconfig/Makefile
including a description as it's not clear on what kind of devices the
chip can be encountered.

Also please properly tag the source files attachments as text/plain.


With a quick glance at the code:
- your comments are often single-line C++ style //
  and should be changed to /*  */.

- comments that look like author/revision tags

- there are blocks of code commented or inside if (1) {}

- some printk calls missing KERN_ severity tag

- indentation issues


Please fix above issues (and have a look at scripts/checkpatch.pl) and
respin (as a patch) taking care to CC netdev so network people have to
chance to see it.

Bruno

View attachment "dm9000_KT2.6.31.c" of type "text/plain" (37105 bytes)

View attachment "dm9000_KT2.6.31.h" of type "text/plain" (4181 bytes)