netdev - Re: mlx4: dropping multicast packets at promisc leave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <505B1874.3040904@mellanox.com>
Date:	Thu, 20 Sep 2012 16:21:56 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Marcelo Ricardo Leitner <mleitner@...hat.com>
CC:	netdev <netdev@...r.kernel.org>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>
Subject: Re: mlx4: dropping multicast packets at promisc leave

On 20/09/2012 03:43, Marcelo Ricardo Leitner wrote:
> I have a report that our mlx4 driver (RHEL 6.3) is dropping multicast 
> packets when NIC leaves promisc mode. It seems this is being cause due 
> to the new steering mode that took place near by commit 
> 1679200f91da6a054b06954c9bd3eeed29b6731f. As it seems, the new 
> steering mode needs more commands/time to leave the promisc mode, 
> which may be leading to packet drops.

Marcelo,

The commit you point on below 6d19993 "net/mlx4_en: Re-design multicast 
attachments flow" makes sure to avoid
doing extra firmware comments and not leave a window in time where 
"correct" addresses are not attached. Its hard to say what's the case on 
that RHEL 6.3 system, it would be very helpful through if you manage to 
reproduce the problem on an upstream kernel -- BTW you didn't say on 
which kernel you are  trying to reproduce  this, note that upstream has 
also commit 60d31c1475f2 "net/mlx4_core: Looking for promiscuous entries 
on the correct port" (reported by you...) , so if somehow this commit 
makes the diff you could use it also on their system.

> It takes 300ms to perform the change there against my 600us. Hitting 
> something like tcpdump -c 10 in a loop helps triggering it.

Do you have any insight for this huge difference?

Or.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html