netdev - Re: [PATCH net-next] ipv6: remove unnecessory call rt6_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120920.010309.616282450923974496.davem@davemloft.net>
Date:	Thu, 20 Sep 2012 01:03:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, gaofeng@...fujitsu.com
Subject: Re: [PATCH net-next] ipv6: remove unnecessory call
 rt6_clean_expires

From: roy.qing.li@...il.com
Date: Thu, 20 Sep 2012 12:57:33 +0800

> From: Li RongQing <roy.qing.li@...il.com>
> 
> ip6_dst_alloc will zero the from and rt6i_flags of dst cache,
> so it is unnecessory to call rt6_clean_expires again.
> 
> Cc: Gao feng <gaofeng@...fujitsu.com>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

You're modifying ip6_blackhole_route() and ip6_route_add().

Only the latter calls ip6_dst_alloc().

I know the change is OK, but your commit message is extremely
inaccurate, please fix it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html