netdev - Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120921.151104.718226045755546422.davem@davemloft.net>
Date:	Fri, 21 Sep 2012 15:11:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	marex@...x.de
Cc:	netdev@...r.kernel.org, david.choi@...rel.com,
	nobuhiro.iwamatsu.yj@...esas.com, fabio.estevam@...escale.com,
	shawn.guo@...aro.org
Subject: Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021

From: Marek Vasut <marex@...x.de>
Date: Fri, 21 Sep 2012 21:06:52 +0200

> You know, youth and all ... I was under the impression the patches shall be 
> checkpatch clean. But you got me there quite well, something must be wrong with 
> my precommit hook.

checkpatch is not a panacea, and it is in particular not an automaton
that one uses without using any human judgement at all.

In particular, checkpatch does not enforce the comment style we use in
the networking code nor several other conventions that we use which
are slightly different from the rest of the tree.

Therefore strick checkpatch conformance is never appropriate.

> Anyway, about the checkpatch cleanup of the file, will that be 
> welcome (afterwards I fix the patchset and repost)?

See above, strict checkpatch cleanups, especially those done in
a completely automaton style with zero human judgment involved,
are not welcome.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html