netdev - Re: [PATCH net-next v2] ipv6: remove unnecessary call rt6_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120921.131948.1085353386239998747.davem@davemloft.net>
Date:	Fri, 21 Sep 2012 13:19:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, gaofeng@...fujitsu.com
Subject: Re: [PATCH net-next v2] ipv6: remove unnecessary call
 rt6_clean_expires

From: roy.qing.li@...il.com
Date: Thu, 20 Sep 2012 13:31:58 +0800

> From: Li RongQing <roy.qing.li@...il.com>
> 
> the from of dst_entry and rt6i_flags of rt6_info have been zeroed out in
> ip6_blackhole_route or after calling ip6_dst_alloc, so it is unnecessary
> to call rt6_clean_expires again.
> 
> Cc: Gao feng <gaofeng@...fujitsu.com>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

I still don't like this change.

The rt6_clean_expires() calls actually do some work (clear the
RTF_EXPIRES) bit in two of the cases you are changing.

And more importantly, having the rt6_clean_expires() call makes
it easier to audit and make sure this is handled in all the
necessary situations.

The whole point of having an abstracted helper function is so
that we don't have code directly manipulating RTF_EXPIRES.

I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html