lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANEcBPTm384oo7znoyuvyBxOBweyFT6Vzv6Cd_OiJ2rB3RJ-hQ@mail.gmail.com> Date: Sat, 22 Sep 2012 17:53:30 +0800 From: Xiaodong Xu <stid.smth@...il.com> To: linux-kernel@...r.kernel.org Cc: netdev@...r.kernel.org Subject: [PATCH] pppoe: drop PPPOX_ZOMBIEs in pppoe_release From: Xiaodong Xu <stid.smth@...il.com> When PPPOE is running over a virtual ethernet interface (e.g., a bonding interface) and the user tries to delete the interface in case the PPPOE state is ZOMBIE, the kernel will loop forever while unregistering net_device for the reference count is not decreased to zero which should have been done with dev_put(). Signed-off-by: Xiaodong Xu <stid.smth@...il.com> --- --- drivers/net/ppp/pppoe.c.orig 2012-09-19 11:49:27.921826868 +0800 +++ drivers/net/ppp/pppoe.c 2012-09-22 17:44:03.642730082 +0800 @@ -570,7 +570,7 @@ static int pppoe_release(struct socket * po = pppox_sk(sk); - if (sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND)) { + if (sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND | PPPOX_ZOMBIE)) { dev_put(po->pppoe_dev); po->pppoe_dev = NULL; } -- Regards, Xiaodong Xu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists