netdev - Re: [PATCH] net: scm: moving dereference after NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120924.155148.1513263823536378183.davem@davemloft.net>
Date:	Mon, 24 Sep 2012 15:51:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	maxin.john@...il.com
Cc:	cxzhang@...son.ibm.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: scm: moving dereference after NULL check

From: "Maxin B. John" <maxin.john@...il.com>
Date: Sun, 23 Sep 2012 13:03:30 -0400

> scm_destroy_cred() dereferences 'scm' before null check
> 
> Signed-off-by: Maxin B. John <maxin.john@...il.com>

Every caller of scm_destroy() passes a non-NULL scm, so the
NULL test can be removed entirely.

I'll do this in net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html