netdev - Re: [PATCH net-next v3] net: use a per task frag allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGK4HS9CFwaiR56tym6=FkhrDBwK62Kvm4qw62BWqUXAu3XbbQ@mail.gmail.com>
Date:	Mon, 24 Sep 2012 11:34:47 -0700
From:	Vijay Subramanian <subramanian.vijay@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Ben Hutchings <bhutchings@...arflare.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>
Subject: Re: [PATCH net-next v3] net: use a per task frag allocator

>
> Successfully tested on various ethernet devices.
> (ixgbe, igb, bnx2x, tg3, mellanox mlx4)
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>
> Cc: Vijay Subramanian <subramanian.vijay@...il.com>
> Cc: Alexander Duyck <alexander.h.duyck@...el.com>
> ---
> v3: net/sched/em_meta.c bit pointed out by Vijay
> v2: uses existing page_frag structure to hold page/offset/size
>     convert linear_to_page()/__ip_append_data()/ip6_append_data()
>     remove @page and @off fields from struct inet_cork
>     move the destructor from tcp_v4_destroy_sock() to sk_common_release

With netperf (64KB send buffer) and with e1000e driver, I get 13%
improvement with v3 of this patch.
When I run netserver and netperf on separate cpus with taskset, I get
7% improvement.

Tested-by: Vijay Subramanian <subramanian.vijay@...il.com>


FYI, checkpatch complained about this patch with 4 lines over 80
characters (which probably be ignored I think) and one
trailing space error.

ERROR: trailing whitespace
#443: FILE: net/ipv4/raw.c:139:
+^Ipr_err("icmp_filter skb_transport_offset %d data-head %ld len %d/%d\n", $


Vijay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html