netdev - Re: [PATCH] ipv6: del unreachable route when an addr is deleted on lo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348580631.26828.3047.camel@edumazet-glaptop>
Date:	Tue, 25 Sep 2012 15:43:51 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	davem@...emloft.net
Subject: Re: [PATCH] ipv6: del unreachable route when an addr is deleted on
 lo

On Tue, 2012-09-25 at 12:24 +0200, Nicolas Dichtel wrote:
> When an address is added on loopback (ip -6 a a 2002::1/128 dev lo), two routes
> are added:
>  - one in the local table:
>     local 2002::1 via :: dev lo  proto none  metric 0
>  - one the in main table (for the prefix):
>     unreachable 2002::1 dev lo  proto kernel  metric 256  error -101
> 
> When the address is deleted, the route inserted in the main table remains
> because we use rt6_lookup(), which returns NULL when dst->error is set, which
> is the case here! Thus, it is better to use ip6_route_lookup() to avoid this
> kind of filter.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>  net/ipv6/addrconf.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 6bc85f7..b6b2f9f 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -788,8 +788,12 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp)
>  		struct in6_addr prefix;
>  		struct rt6_info *rt;
>  		struct net *net = dev_net(ifp->idev->dev);
> +		struct flowi6 fl6 = {};
>  		ipv6_addr_prefix(&prefix, &ifp->addr, ifp->prefix_len);
> -		rt = rt6_lookup(net, &prefix, NULL, ifp->idev->dev->ifindex, 1);
> +		fl6.flowi6_oif = ifp->idev->dev->ifindex;
> +		fl6.daddr = prefix;
> +		rt = (struct rt6_info *)ip6_route_lookup(net, &fl6,
> +							 RT6_LOOKUP_F_IFACE);
>  

rt cant be NULL here ( but can be ip6_null_entry )

>  		if (rt && addrconf_is_prefix_route(rt)) {

So this condition is obsolete...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html