lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <OF79035384.7768EDE1-ONC1257A84.004D7D9C-C1257A84.004DCE48@transmode.se> Date: Tue, 25 Sep 2012 16:09:50 +0200 From: Joakim Tjernlund <joakim.tjernlund@...nsmode.se> To: Francois Romieu <romieu@...zoreil.com> Cc: netdev@...r.kernel.org Subject: Re: [PATCH v3] ucc_geth: Lockless xmit Francois Romieu <romieu@...zoreil.com> wrote on 2012/09/24 23:10:14: > > Joakim Tjernlund <joakim.tjernlund@...nsmode.se> : > [...] > > I don't get it. The skb test is there just for one special case, when > > the BD ring is empty the (bd_status & T_R) == 0 will be true as well so > > one need something more than the bd_status test. > > Sure but the converse is not true : (bd_status & T_R) == 0 && skb does not > mean that the skb has been sent. It happens when said skb is about to be > given to the hardware by hard_start_xmit as well. duhh, I was too tired when trying to make sense of smp & racing in general, thanks. Will probably be some time before I get to this again due to other stuff though. The other patches are independent of this one, I hope they are good/accepted? Jocke -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists