lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1348643247.5093.32.camel@edumazet-glaptop>
Date:	Wed, 26 Sep 2012 09:07:27 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Gao feng <gaofeng@...fujitsu.com>
Cc:	davem@...emloft.net, netfilter-devel@...r.kernel.org,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	pablo@...filter.org, steffen.klassert@...unet.com,
	linux-crypto@...r.kernel.org, jengelh@...i.de,
	stephen.hemminger@...tta.com
Subject: Re: [PATCH 01/11] netlink: add reference of module in
 netlink_dump_start

On Wed, 2012-09-26 at 12:52 +0800, Gao feng wrote:

> +int netlink_dump_done(struct netlink_callback *cb)
> +{
> +	if (cb->module)
> +		module_put(cb->module);
> +	return 0;
> +}
> +EXPORT_SYMBOL(netlink_dump_done);
> +

No need to test cb->module being not NULL


int netlink_dump_done(struct netlink_callback *cb)
{
	module_put(cb->module);
	return 0;
}

Same remark for try_module_get() call


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ