netdev - Re: [PATCH 5/5] smsc95xx: enable power saving mode during system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87txuk9453.fsf@nemi.mork.no>
Date:	Wed, 26 Sep 2012 17:48:24 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Steve Glendinning <steve@...well.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] smsc95xx: enable power saving mode during system suspend

Steve Glendinning <steve@...well.net> writes:
> On 26 September 2012 15:23, Bjørn Mork <bjorn@...k.no> wrote:
>> Steve Glendinning <steve.glendinning@...well.net> writes:
>>
>>> +static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message)
>>> +{
>>> +     struct usbnet *dev = usb_get_intfdata(intf);
>>> +     int ret;
>>> +     u32 val;
>>> +
>>> +     BUG_ON(!dev);
>>
>> That's not very user friendly.  Why not just return here?
>
> I hadn't thought that was a situation that could arise, is it?  Would
> this happen if the USB device was removed during suspend?

No, it should not happen.  But then, why test at all?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html