lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <50646DEB.8020400@lwfinger.net> Date: Thu, 27 Sep 2012 10:16:59 -0500 From: Larry Finger <Larry.Finger@...inger.net> To: Joe Perches <joe@...ches.com> CC: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Chaoming Li <chaoming_li@...lsil.com.cn>, "David S. Miller" <davem@...emloft.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] rtlwifi: use %*ph[C] to dump small buffers On 09/26/2012 11:45 AM, Joe Perches wrote: > > rate_mask uses: > > u32 ratr_bitmap = (u32) mac->basic_rates; > ... > u8 rate_mask[5]; > ... > [sets ratr_bitmap as u32] > ... > *(u32 *)&rate_mask = ((ratr_bitmap & 0x0fffffff) | > ratr_index << 28); > ... > rtl92c_fill_h2c_cmd(hw, H2C_RA_MASK, 5, rate_mask); > > Looks like a possible endian misuse to me. Joe, I had to track the flow through two more routines, but I think your analysis is correct. The only BE platform I have does not have any PCIe hardware, thus I can only test the USB version. It does not show a major problem, but this one with the rate masks would be subtle. Thanks, Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists