lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <EB1619762EAF8B4E97A227FB77B7E0293E9EC49D@DBDE01.ent.ti.com> Date: Thu, 27 Sep 2012 18:40:13 +0000 From: "N, Mugunthan V" <mugunthanvnm@...com> To: Daniel Mack <zonque@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "Hiremath, Vaibhav" <hvaibhav@...com>, "David S. Miller" <davem@...emloft.net> Subject: RE: [PATCH] net: ti cpsw ethernet: set IFCTL_A bit in MACCONTROL > -----Original Message----- > From: Daniel Mack [mailto:zonque@...il.com] > Sent: Thursday, September 27, 2012 5:21 PM > To: netdev@...r.kernel.org > Cc: Daniel Mack; N, Mugunthan V; Hiremath, Vaibhav; David S. Miller > Subject: [PATCH] net: ti cpsw ethernet: set IFCTL_A bit in MACCONTROL > > For RMII/RGMII mode operation in 100Mbps, the CPSW needs to set the > IFCTL_A bits in the MACCONTROL register. For all other PHY modes, this > bit is unused, so setting it unconditionally shouldn't cause any > trouble. > > Signed-off-by: Daniel Mack <zonque@...il.com> > Cc: Mugunthan V N <mugunthanvnm@...com> > Cc: Vaibhav Hiremath <hvaibhav@...com> > Cc: David S. Miller <davem@...emloft.net> > --- > drivers/net/ethernet/ti/cpsw.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/ti/cpsw.c > b/drivers/net/ethernet/ti/cpsw.c > index aa78168..b764f75 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -386,6 +386,11 @@ static void _cpsw_adjust_link(struct cpsw_slave > *slave, > mac_control |= BIT(7); /* GIGABITEN */ > if (phy->duplex) > mac_control |= BIT(0); /* FULLDUPLEXEN */ > + > + /* set speed_in input in case RMII mode is used in >10Mbps > */ > + if (phy->speed > 10) Please change the speed check as == 100 as it is required only for 100Mbps link Regards Mugunthan V N > + mac_control |= BIT(15); > + > *link = true; > } else { > mac_control = 0; > -- > 1.7.11.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists