netdev - You have to fix this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120927.183406.962014014858457666.davem@davemloft.net>
Date:	Thu, 27 Sep 2012 18:34:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vipul@...lsio.com
CC:	netdev@...r.kernel.org
Subject: You have to fix this


You cannot put such monster sized local data objects on the stack:

drivers/net/ethernet/chelsio/cxgb4/t4_hw.c: In function ‘t4_memory_rw.constprop.6’:
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:484:1: warning: the frame size of 2056 bytes is larger than 2048 bytes [-Wframe-larger-than=]

That's because of this thing:

		__be32 data[MEMWIN0_APERTURE/sizeof(__be32)];

I'm really surprised this didn't show up in any of your test builds.
Or are you ignoring warnings that your changes add?