[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120928.024034.1426515423229309957.davem@davemloft.net>
Date: Fri, 28 Sep 2012 02:40:34 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: Sathya.Perla@...lex.Com
Cc: netdev@...r.kernel.org
Subject: Re: [net-next PATCH 4/5] be2net: get rid of AMAP_SET/GET macros in
TX path
From: "Perla, Sathya" <Sathya.Perla@...lex.Com>
Date: Fri, 28 Sep 2012 05:47:25 +0000
> endianness is handled even in this patch. The call to wrb_fill_hdr()
> is followed by be_dws_cpu_to_le() to handle this.
That swap_dws() thing is the most inefficient thing I've ever seen.
Instead of being able to benefit from compile time optimizations
such as byte swaps of constants, you do everything hidden from the
compiler so nothing gets optimized.
The aspect you are changing is the least of your problems in this
area.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists